Increase visibility of gitjob controller logs and events #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
force-pushed
the
events-add-fleet-prefix
branch
from
4c38163 to
35a5d8c
Compare
manno
approved these changes
Sep 27, 2024
This will help users find events produced by Fleet, whether through the Rancher UI or `kubectl` for instance.
This makes reconciliation, resource creation, deletion and status update errors for `GitRepo`s more visible, ensuring that they appear in logs even when debug logging is disabled.
This will help map logs on `GitRepo`s, produced by the `gitjob` reconciler, with those on corresponding bundles from their reconciler.
This will help map logs referring to a bundle with those referring to its `GitRepo`, across the `fleet` and `gitjob` controllers.
manno
approved these changes
Sep 27, 2024
manno
reviewed
Sep 27, 2024
This clarifies what events are about, as concisely as possible,.
weyfonk
force-pushed
the
events-add-fleet-prefix
branch
from
9db6999 to
e9ba3a2
Compare
manno
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
fleet_prefix to Kubernetes events generated by thegitjobcontroller, to clarify their context.It also lowers verbosity of log messages indicating creation, deletion or reconciliation of
GitRepos, making them visible when debug logging is disabled.