Add theme support for automatic favicon tinting #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements automatic tinting for monochrome SVG icons to improve visibility across light and dark themes. This addresses the issue where dark icons (like GitHub's) become invisible on dark backgrounds. Key changes: - Add optional `theme` parameter to API (light/dark) - Detect and tint monochrome SVG icons based on theme preference - Special handling for GitHub icons which are always treated as monochrome - Preserve original colors for non-monochrome icons - No processing overhead when theme is not specified The tinting logic: - Detects grayscale colors (R, G, B values within 30 units) - Light theme: tints dark icons to #333333 - Dark theme: tints light icons to #E0E0E0 - Colorful icons (red, blue, etc.) are preserved as-is 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GitHub and other websites provide dark favicons that become invisible on dark backgrounds. Most websites don't provide theme-specific favicon variants, making it difficult to maintain icon visibility across different themes.
Solution
This PR implements automatic tinting for monochrome SVG icons based on theme preference. When a theme parameter is specified, the service detects monochrome icons and applies appropriate colors for better visibility.
Key Features
Implementation Details
Monochrome Detection Logic
Performance
Testing
Files Changed