dhcpv6: allow creating new bindings on REBIND #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be unassigned IAs among the options the client sends when it issues a REBIND. In fact, that's how the ISC dhclient reqests new IA_PDs to be assigned. However, odhcpd would just return the IA_PDs back without assigning a prefix: $ dhclient -6 -d -lf $PWD/leases eth0 -N XMT: Forming Solicit, 0 ms elapsed. XMT: X-- IA_NA 00:3b:dd:9d RCV: Advertise message on eth2 from fe80::5054:ff:feba:444e. RCV: X-- IA_NA 00:3b:dd:9d ^C $ dhclient -6 -d -lf $PWD/leases eth0 -N -P XMT: Forming Rebind, 0 ms elapsed. XMT: X-- IA_NA 00:3b:dd:9d XMT: X-- IA_PD 00:3b:dd:9d RCV: Reply message on eth2 from fe80::5054:ff:feba:444e. RCV: X-- IA_NA 00:3b:dd:9d RCV: X-- IA_PD 00:3b:dd:9d RCV: | !-- Status code of no prefix, IA_PD discarded. That is neither too useful, nor consistent with what the ISC dhcpcd does, nor does it seem correct. Notably, it breaks NetworkManager's IPv6 connection sharing that utilizes the ISC dhclient and needs to request the prefixes as-needed on networks with OpenWRT. The attached patch moves the REBIND handling to the branch that is able to add new bindings. It then, perhaps unnecessarily, also allows obtaining new IA_NAs this way. (While the patch fixes the issue for me, I'm not too familiar with the odhcpd code base, so a careful review is needed.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be unassigned IAs among the options the client sends when it
issues a REBIND. In fact, that's how the ISC dhclient reqests new IA_PDs
to be assigned. However, odhcpd would just return the IA_PDs back
without assigning a prefix:
That is neither too useful, nor consistent with what the ISC dhcpcd does,
nor does it seem correct. Notably, it breaks NetworkManager's IPv6
connection sharing that utilizes the ISC dhclient and needs to request the
prefixes as-needed on networks with OpenWRT.
The attached patch moves the REBIND handling to the branch that is able
to add new bindings. It then, perhaps unnecessarily, also allows
obtaining new IA_NAs this way.
(While the patch fixes the issue for me, I'm not too familiar with the
odhcpd code base, so a careful review is needed.)