Fm/tar reproducible #111
Merged
Fm/tar reproducible #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilari
force-pushed
the
fm/tar-reproducible
branch
3 times, most recently
from
79ac550 to
1664088
Compare
Collaborator
|
Can you provide a test for this functionality? Messing around with owners and the directory listing order is not needed I think, but the timestamp could be tested. |
Collaborator
|
We also compress the tarball, there might be some reproducibility issues there too. For example for |
Collaborator
|
For compatibility reasons (#100) it might also be useful to have the timestamp as option for the CLI. |
tamilari
force-pushed
the
fm/tar-reproducible
branch
4 times, most recently
from
ddc62d8 to
85046ad
Compare
Urist-McGit
reviewed
Oct 29, 2025
Urist-McGit
reviewed
Oct 30, 2025
Urist-McGit
reviewed
Oct 30, 2025
Urist-McGit
reviewed
Oct 30, 2025
Collaborator
|
62f4dc4 is two commits: one that fixes the unclosed session and one that refactors the session handling. Please split it |
Collaborator
|
Same goes for 85046ad: split them so the first commit adds lz4 to the parametrized test, and the second adds the mtime tests. |
fmoessbauer
reviewed
Oct 30, 2025
Member
fmoessbauer
left a comment
fmoessbauer
left a comment
There was a problem hiding this comment.
In general, this already looks pretty good. Just some minor aspects.
fmoessbauer
reviewed
Oct 30, 2025
tamilari
force-pushed
the
fm/tar-reproducible
branch
from
85046ad to
b734ff1
Compare
tamilari
force-pushed
the
fm/tar-reproducible
branch
from
b734ff1 to
dba28ff
Compare
fmoessbauer
reviewed
Oct 31, 2025
fmoessbauer
reviewed
Oct 31, 2025
tamilari
force-pushed
the
fm/tar-reproducible
branch
2 times, most recently
from
c512183 to
0d3e1a2
Compare
fmoessbauer
approved these changes
Nov 3, 2025
As a preparation to repack reproducible, we pin the owner and sorting of the files within the tar. Signed-off-by: Felix Moessbauer <[email protected]>
To achieve repack reproducible, use the timestamp from the latest changelog for tar creation. Use the -n / --no-name gzip option to not save the original timestamp. Closes: siemens#100 ("reproducible result for source-merge") Signed-off-by: Tamino Larisch <[email protected]>
Before, the --output option for the source-merge command was just ignored. Fixes: 3ad934d ("feat(merger): add infrastructure to create ...") Signed-off-by: Tamino Larisch <[email protected]>
Move the input arguments that are useful for the source-merge and repack commands into a mixin. This simplifies maintenance and prepares for the addition of another option needed for both commands. Signed-off-by: Tamino Larisch <[email protected]>
Add the --mtime cli option to the repack and source-merge commands. This sets the mtime for the tar command. If this option is not set, the timestamp from the most recent changelog is used for reproducible builds, as before. Signed-off-by: Tamino Larisch <[email protected]>
fixes: 221b60f ("test: use custom user agent in all online tests") Signed-off-by: Tamino Larisch <[email protected]>
Use the http_session fixture with the custom user agent to download "some_packages". To keep the session fixture scope from "some_packages", the http_session fixture will now only be created once per session. These test packages should only be downloaded once, even if they will be required for additional tests in the future. fixes: 221b60f ("test: use custom user agent in all online tests") Signed-off-by: Tamino Larisch <[email protected]>
Signed-off-by: Tamino Larisch <[email protected]>
tamilari
force-pushed
the
fm/tar-reproducible
branch
from
0d3e1a2 to
9d5e9eb
Compare
This change aims to drastically reduce test times. Signed-off-by: Tamino Larisch <[email protected]>
Signed-off-by: Tamino Larisch <[email protected]>
tamilari
force-pushed
the
fm/tar-reproducible
branch
from
9d5e9eb to
f7fd852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.