chore(cache): gracefully parse deb822 cache data #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urist-McGit
reviewed
Nov 5, 2025
fmoessbauer
force-pushed
the
fm/graceful-degradation
branch
from
b8cc2b0 to
a6b4bf3
Compare
We observed cases in the field where a third party debian repo provider (in this case Artifactory) generates incorrect deb822 data. This error remained unnoticed, as apt itself does not extract the incorrect fields. This patch makes the parser gracefully degradate by skipping incorrect entries but continuing anyways. Signed-off-by: Felix Moessbauer <[email protected]>
The test data is taken from an Artifactory repository. Without graceful degradation, this test fails. Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/graceful-degradation
branch
from
a6b4bf3 to
f835c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed cases in the field where a third party debian repo provider (in this case Artifactory) generates incorrect deb822 data. This error remained unnoticed, as apt itself does not extract the incorrect fields.
This patch makes the parser gracefully degradate by skipping incorrect entries but continuing anyways.