Add unit tests for all missing components, along with minor improvements #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urist-McGit
reviewed
Sep 9, 2025
fmoessbauer
force-pushed
the
fm/add-tests
branch
from
a257757 to
6eb253c
Compare
Urist-McGit
reviewed
Sep 9, 2025
fmoessbauer
force-pushed
the
fm/add-tests
branch
2 times, most recently
from
c9ddcb4 to
8a92a8a
Compare
Fixes: 4d3cc54 ("feat: add client to query snapshot.debian.org") Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/add-tests
branch
from
8a92a8a to
b3b151c
Compare
The snapshot service reportes the first_seen entry of a file as iso8601 timestamp instead of a unix timestamp. As we internally represent it as an integer (unix timestamp), we need to convert it. Fixes: 4d3cc54 ("feat: add client to query snapshot.debian.org") Signed-off-by: Felix Moessbauer <[email protected]>
As we resolve the source package lazy, all methods that operate on an invalid source package need to raise the NotFoundOnSnapshotError in case it is missing. We now add this for the binpackages case, where currently the generic SnapshotDataLakeError is thrown in this case. Signed-off-by: Felix Moessbauer <[email protected]>
After downloading we clear the list of items to download so that we can reuse the same object again. Signed-off-by: Felix Moessbauer <[email protected]>
When downloading files, we return the on-disk path for each file after download. By that, the caller does not need to guess the filename, but can just examine the result. As we yield the data, the caller further can track progress. Signed-off-by: Felix Moessbauer <[email protected]>
Signed-off-by: Felix Moessbauer <[email protected]>
Some tests interact with external services. Mark these, so we can easily exclude them when testing in isolated environments. Signed-off-by: Felix Moessbauer <[email protected]>
Signed-off-by: Felix Moessbauer <[email protected]>
Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/add-tests
branch
from
b3b151c to
7331bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By that, we get close to 95% code coverage. For details, please see the individual commits.