refactor(tree-view): replace h5 with si-h5 class styling #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintankavathia
force-pushed
the
refactor/tree/h5
branch
2 times, most recently
from
d40f7f7 to
c7abbb7
Compare
|
Documentation. Coverage Reports: |
chintankavathia
force-pushed
the
refactor/tree/h5
branch
from
c7abbb7 to
ea284ab
Compare
chintankavathia
force-pushed
the
refactor/tree/h5
branch
from
ea284ab to
2344fc7
Compare
|
|
Collaborator
|
🎉 This PR is included in version 48.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using semantic tag makes no sense in this context.
Replace h5 element with div for tree item labels
Apply si-h5 class conditionally only when selection is enabled and item is selected
Remove h5-specific font size and weight variables from tree-view-variables.scss
Remove h5 styling rules from si-tree-view-item.component.scss
Simplify CSS by removing redundant nested selector for selected item heading weight
I confirm that this MR follows the contribution guidelines.