Skip to content

fix(core/field-wrapper):empty tooltip will not render when hover overed field #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+77 −2
Open

fix(core/field-wrapper):empty tooltip will not render when hover overed field #2171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37728de
update hasAnyText method to check for state also
lakshmi-priya-b Sep 29, 2025
22d60ea
update test cases
lakshmi-priya-b Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/core/src/components/field-wrapper/helper-text-util.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,31 @@ import {

export function hasAnyText({
invalidText,
isInvalid,
warningText,
isWarning,
infoText,
isInfo,
validText,
isValid,
helperText,
}: {
invalidText?: string;
isInvalid?: boolean;
warningText?: string;
isWarning?: boolean;
infoText?: string;
isInfo?: boolean;
validText?: string;
isValid?: boolean;
helperText?: string;
}) {
return [invalidText, warningText, infoText, validText, helperText].some(
(text) => text?.trim()
return (
(isInvalid && invalidText?.trim()) ||
(isWarning && warningText?.trim()) ||
(isInfo && infoText?.trim()) ||
(isValid && validText?.trim()) ||
helperText?.trim()
);
}

Expand Down
63 changes: 63 additions & 0 deletions packages/core/src/components/field-wrapper/tests/field-wrapper.ct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,3 +200,66 @@ regressionTest(
await expect(helperTextElement).toHaveCount(1);
}
);

regressionTest(
'should not show empty tooltip if invalidText is present but isInvalid is false and no helperText',
async ({ mount, page }) => {
await mount(
`
<ix-field-wrapper
invalid-text="This invalid message should be ignored"
show-text-as-tooltip
>
<div style="position: relative; width: 100%; height: 2rem; background: red;">Content</div>
</ix-field-wrapper>
`
);

const fieldWrapperElement = page.locator('ix-field-wrapper');
await expect(fieldWrapperElement).toHaveClass(/hydrated/);

const bottomTextElement = fieldWrapperElement
.locator('.field-bottom')
.locator('ix-typography.bottom-text');
await expect(bottomTextElement).toHaveCount(0);

await page.mouse.move(10, 10);
await page.waitForTimeout(500);

const tooltip = fieldWrapperElement.locator('ix-tooltip');
await expect(tooltip).toHaveCount(0);
await expect(tooltip).not.toBeVisible();
}
);
regressionTest(
'should not show tooltip if invalidText is an empty string even when isInvalid is true',
async ({ mount, page }) => {
await mount(
`
<ix-field-wrapper
<ix-field-wrapper
invalid-text=""
is-invalid
show-text-as-tooltip
>
<div style="position: relative; width: 100%; height: 2rem; background: red;">Content</div>
</ix-field-wrapper>
`
);
const fieldWrapperElement = page.locator('ix-field-wrapper');
await expect(fieldWrapperElement).toHaveClass(/hydrated/);

const bottomTextElement = fieldWrapperElement
.locator('.field-bottom')
.locator('ix-typography.bottom-text');
await expect(bottomTextElement).toHaveCount(0);

await page.mouse.move(10, 10);
await page.waitForTimeout(500);

const tooltip = fieldWrapperElement.locator('ix-tooltip');

await expect(tooltip).toHaveCount(0);
await expect(tooltip).not.toBeVisible();
}
);