-
Notifications
You must be signed in to change notification settings - Fork 116
fix(core/tooltip):update padding and align icon size with figma #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(core/tooltip):update padding and align icon size with figma #2189
Conversation
🦋 Changeset detectedLatest commit: 13bb765 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @lakshmi-priya-b, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses visual discrepancies in the tooltip component by refining its padding and ensuring proper alignment and consistent sizing of icons within the tooltip title, all in accordance with Figma design guidelines. Additionally, it enhances the reliability of the tooltip's visual regression tests by standardizing viewport settings and introducing a comparison threshold. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix UI inconsistencies in the tooltip component by updating its padding and aligning the title icon according to Figma designs. The changes involve modifying SCSS for styling and updating the component's TypeScript logic to enforce a fixed size for the slotted icon. The visual regression tests have also been updated to accommodate these style changes. My review found an issue in the component's JSDoc that should be addressed.
nuke-ellington
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should set the icon size to 16 explicitly in the examples
|
|
||
| /** | ||
| * @slot title-icon - Icon of tooltip title | ||
| * @slot title-icon - Icon of tooltip title. The icon will be displayed as 16x16px. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * @slot title-icon - Icon of tooltip title. The icon will be displayed as 16x16px. | |
| * @slot title-icon - Icon displayed next to the tooltip title. The icon will be displayed as 16x16px. |
|
Also check sonar issues please |
…-2720/tooltip-icon-padding-misalign
Added new preview examples for tooltip-with icon and set the icon size to 16 explicitly. |
|



💡 What is the current behavior?
Currently the padding for the tooltip container is not matching with figma and the tooltip icon is misaligned with the first line of the tooltip title.
JIRA Ticket: IX-2720
GitHub Issue Number: #
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support