Skip to content

Conversation

@lakshmi-priya-b
Copy link
Contributor

💡 What is the current behavior?

Currently the padding for the tooltip container is not matching with figma and the tooltip icon is misaligned with the first line of the tooltip title.

JIRA Ticket: IX-2720

GitHub Issue Number: #

🆕 What is the new behavior?

  • The padding for the tooltip container is according to the figma.
  • Tooltip icon is aligned with the first line of the tooltip title after adding some top-margin.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📕 Add or update a Storybook story
  • 📄 Documentation was reviewed/updated siemens/ix-docs
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025

🦋 Changeset detected

Latest commit: 13bb765

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siemens/ix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lakshmi-priya-b, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses visual discrepancies in the tooltip component by refining its padding and ensuring proper alignment and consistent sizing of icons within the tooltip title, all in accordance with Figma design guidelines. Additionally, it enhances the reliability of the tooltip's visual regression tests by standardizing viewport settings and introducing a comparison threshold.

Highlights

  • Tooltip Padding Adjustment: The padding for the tooltip container has been updated to 0.375rem for top/bottom and 0.75rem for left/right, aligning it with Figma design specifications.
  • Tooltip Icon Alignment: The alignment of the tooltip icon with the title has been improved by adjusting its margin to 0.125rem 0.25rem 0.125rem 0 and removing the align-items: center property from the title container, ensuring better visual consistency.
  • Consistent Icon Sizing: A new slot change handler (handleTitleIconSlotChange) has been implemented to automatically set the size of any slotted ix-icon within the tooltip title to 16x16px, ensuring uniform icon presentation.
  • Visual Regression Test Enhancements: Visual regression tests for the tooltip component have been updated to include specific viewport sizes for consistency and a threshold: 0.05 for snapshot comparisons, making the tests more robust against minor pixel variations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix UI inconsistencies in the tooltip component by updating its padding and aligning the title icon according to Figma designs. The changes involve modifying SCSS for styling and updating the component's TypeScript logic to enforce a fixed size for the slotted icon. The visual regression tests have also been updated to accommodate these style changes. My review found an issue in the component's JSDoc that should be addressed.

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set the icon size to 16 explicitly in the examples


/**
* @slot title-icon - Icon of tooltip title
* @slot title-icon - Icon of tooltip title. The icon will be displayed as 16x16px.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @slot title-icon - Icon of tooltip title. The icon will be displayed as 16x16px.
* @slot title-icon - Icon displayed next to the tooltip title. The icon will be displayed as 16x16px.

@nuke-ellington nuke-ellington added this to the 4.0.0 milestone Oct 14, 2025
@nuke-ellington
Copy link
Collaborator

Also check sonar issues please

@lakshmi-priya-b
Copy link
Contributor Author

We should set the icon size to 16 explicitly in the examples

Added new preview examples for tooltip-with icon and set the icon size to 16 explicitly.

@sonarqubecloud
Copy link

@danielleroux danielleroux removed this from the 4.0.0 milestone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants