fix(core/pane-layout):update a method to render pane on small screen #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfa3e8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…-3326/pane-layout-small-screen
…m/lakshmi-priya-b/ix into fix-3326/pane-layout-small-screen
Contributor
Author
Added test cases |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
In ix-pane-layout the panes don't show up on small window sizes. If the user opens the the page on a larger screen and then resize to smaller, the collapsed pane stays visible at the bottom. Upon (re-)loading the page on a small screen the pane disappears until the screen is enlarged.
GitHub Issue Number: #2157
🆕 What is the new behavior?
Now when the pane is set to render correctly if the user opens the page on a larger screen and then resize to smaller and upon reloading the page on a small screen the pane does not disappear.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support