Skip to content

Conversation

@lzeiml
Copy link
Collaborator

@lzeiml lzeiml commented Nov 6, 2025

  • fix the test config
  • add missing tsconfig

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

⚠️ No Changeset found

Latest commit: bca18d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lzeiml
Copy link
Collaborator Author

lzeiml commented Nov 6, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes configuration issues for the aggrid package, primarily for testing. The changes include adding a tsconfig.node.json for Node-specific files, updating the Playwright configuration, and cleaning up the Vite configuration. My review provides suggestions to enhance the new TypeScript configuration for better adherence to modern standards and to fix an incorrect file path, ensuring the configurations are correctly type-checked.

lzeiml and others added 3 commits November 6, 2025 16:24
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@lzeiml lzeiml marked this pull request as ready for review November 7, 2025 09:10
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants