-
Notifications
You must be signed in to change notification settings - Fork 116
fix(aggrid): fix configuration issues #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lzeiml
commented
Nov 6, 2025
- fix the test config
- add missing tsconfig
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes configuration issues for the aggrid package, primarily for testing. The changes include adding a tsconfig.node.json for Node-specific files, updating the Playwright configuration, and cleaning up the Vite configuration. My review provides suggestions to enhance the new TypeScript configuration for better adherence to modern standards and to fix an incorrect file path, ensuring the configurations are correctly type-checked.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…/siemens/ix into fix/aggrid-visual-testing-config
|


