[Demo] fix and add for demo #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiaobeicn
commented
Sep 27, 2024
xiaobeicn
commented
- Add ENCODER_API_TYPE to readme
- Add save instance dump to run_costorm_gpt
- Fix OpenAIEmbeddingModel repeated
Yucheng-Jiang
approved these changes
Sep 27, 2024
Collaborator
Yucheng-Jiang
left a comment
Yucheng-Jiang
left a comment
There was a problem hiding this comment.
Thanks for contributing! Looks good to me.
feldges
pushed a commit
to feldges/storm
that referenced
this pull request
Dec 4, 2024
fix encoder documentation; add costorm-runner instance dumping in the example script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.