Skip to content

Conversation

@ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 23, 2025

See #32644
Telescopes on #32874

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-32799-sha-056a80fc. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-32799-sha-056a80fc
Triggered by @ghengeveld
Repository storybookjs/storybook
Branch checklist-tasks
Commit 056a80fc
Datetime Mon Nov 10 21:54:37 UTC 2025 (1762811677)
Workflow run 19247345540

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=32799

@ghengeveld ghengeveld self-assigned this Oct 23, 2025
@ghengeveld ghengeveld changed the base branch from next to onboarding-checklist October 23, 2025 07:16
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch checklist-tasks

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Oct 23, 2025

View your CI Pipeline Execution ↗ for commit 056a80f

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-10 22:13:16 UTC

@storybook-app-bot
Copy link

storybook-app-bot bot commented Oct 23, 2025

Package Benchmarks

Commit: 056a80f, ran on 10 November 2025 at 22:07:52 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-onboarding

Before After Difference
Dependency count 0 0 0
Self size 333 KB 56 KB 🎉 -276 KB 🎉
Dependency size 670 B 670 B 0 B
Bundle Size Analyzer Link Link

@storybook/builder-webpack5

Before After Difference
Dependency count 187 187 0
Self size 73 KB 73 KB 0 B
Dependency size 31.90 MB 31.88 MB 🎉 -20 KB 🎉
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 43 43 0
Self size 23.06 MB 24.88 MB 🚨 +1.81 MB 🚨
Dependency size 17.36 MB 17.36 MB 0 B
Bundle Size Analyzer Link Link

@storybook/angular

Before After Difference
Dependency count 187 187 0
Self size 126 KB 126 KB 0 B
Dependency size 30.04 MB 30.02 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@storybook/ember

Before After Difference
Dependency count 191 191 0
Self size 17 KB 17 KB 🎉 -24 B 🎉
Dependency size 28.62 MB 28.60 MB 🎉 -20 KB 🎉
Bundle Size Analyzer Link Link

@storybook/nextjs

Before After Difference
Dependency count 533 533 0
Self size 749 KB 749 KB 0 B
Dependency size 58.95 MB 58.93 MB 🎉 -20 KB 🎉
Bundle Size Analyzer Link Link

@storybook/nextjs-vite

Before After Difference
Dependency count 124 124 0
Self size 3.83 MB 3.83 MB 0 B
Dependency size 21.78 MB 21.87 MB 🚨 +93 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 157 157 0
Self size 31 KB 31 KB 0 B
Dependency size 23.13 MB 23.11 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-vite

Before After Difference
Dependency count 114 114 0
Self size 37 KB 37 KB 0 B
Dependency size 19.69 MB 19.66 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react-webpack5

Before After Difference
Dependency count 273 273 0
Self size 25 KB 25 KB 0 B
Dependency size 43.90 MB 43.88 MB 🎉 -20 KB 🎉
Bundle Size Analyzer Link Link

@storybook/server-webpack5

Before After Difference
Dependency count 199 199 0
Self size 17 KB 17 KB 0 B
Dependency size 33.16 MB 33.14 MB 🎉 -20 KB 🎉
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 187 187 0
Self size 928 KB 928 KB 🎉 -84 B 🎉
Dependency size 73.02 MB 74.82 MB 🚨 +1.79 MB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 169 169 0
Self size 35 KB 35 KB 0 B
Dependency size 69.45 MB 71.25 MB 🚨 +1.80 MB 🚨
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 44 44 0
Self size 1.55 MB 1.55 MB 0 B
Dependency size 40.42 MB 42.24 MB 🚨 +1.81 MB 🚨
Bundle Size Analyzer node node

@storybook/preset-react-webpack

Before After Difference
Dependency count 170 170 0
Self size 21 KB 21 KB 0 B
Dependency size 31.22 MB 31.20 MB 🎉 -20 KB 🎉
Bundle Size Analyzer Link Link

@storybook/react

Before After Difference
Dependency count 57 57 0
Self size 829 KB 829 KB 0 B
Dependency size 12.94 MB 12.92 MB 🎉 -22 KB 🎉
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld force-pushed the checklist-tasks branch 5 times, most recently from 9e334b3 to 090a9f8 Compare October 31, 2025 14:52
@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/19066601453

@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/19066665012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants