Stops using python 2.7 since reached EOL #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the compiler to use the python version in the system, so it makes it compatible with FreeBSD 13.0 (that has python 3.7 available in ports) and also previous versions of FreeBSD (if they happen to use Python 2.7)
Owner
|
Python 2.7 still needed to build node 12 for atom package manager (apm). (Poudriere build fails without When apm switches to use node 14 or later, we can remove |
Author
|
I understand. Thanks for the feedback. If I get it correctly this change only affects atom and not node (node still compiles using 2.7 as you said/different repos). At least I did compile atom with this change and was able to update atom addons. That said, I did not used poudriere so I was not aware of that failing issue you mention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the compiler to use the python version in the system, so it makes it compatible with FreeBSD 13.0 (that has python 3.7 available in ports) and also previous versions of FreeBSD (even if they happen to use Python 2.7)