Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
Security -- in case of vulnerabilities.
-->

## [0.21.1]

### Fixed
- CLI gets all messed up on USBTMC

## [0.21.0]

### Added
Expand Down Expand Up @@ -273,7 +278,8 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
- Feature to retrieve TSP-Link network details

<!--Version Comparison Links-->
[Unreleased]: https://github.com/tektronix/tsp-toolkit-kic-cli/compare/v0.21.0...HEAD
[Unreleased]: https://github.com/tektronix/tsp-toolkit-kic-cli/compare/v0.21.1...HEAD
[0.21.1]: https://github.com/tektronix/tsp-toolkit-kic-cli/releases/tag/v0.21.1
[0.21.0]: https://github.com/tektronix/tsp-toolkit-kic-cli/releases/tag/v0.21.0
[0.20.1]: https://github.com/tektronix/tsp-toolkit-kic-cli/releases/tag/v0.20.1
[0.20.0]: https://github.com/tektronix/tsp-toolkit-kic-cli/releases/tag/v0.20.0
Expand Down
16 changes: 8 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ members = [
resolver = "2"

[workspace.package]
version = "0.21.0"
version = "0.21.1"
authors = ["Tektronix, Inc."]
edition = "2021"
repository = "https://github.com/tektronix/tsp-toolkit-kic-cli"
Expand Down
19 changes: 12 additions & 7 deletions instrument-repl/src/repl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,12 @@ impl Repl {
}
}
if get_error {
let errors = self.get_errors()?;
let (errors, new_prompt) = self.get_errors()?;
for e in errors {
error!("TSP error: {e}");
Self::print_data(*state, ParsedResponse::TspError(e.to_string()))?;
}
prompt = true;
prompt = new_prompt;
*state = Some(ReadState::DataReadEnd);
}
debug!("Data handling complete");
Expand Down Expand Up @@ -203,7 +203,7 @@ impl Repl {
debug!("Writing common script to instrument completed");

self.inst.write_all(b"_KIC.prompts_enable(true)\n")?;
let errors = self.get_errors()?;
let (errors, _) = self.get_errors()?;
for e in errors {
error!("TSP error: {e}");
Self::print_data(None, ParsedResponse::TspError(e.to_string()))?;
Expand Down Expand Up @@ -260,7 +260,7 @@ impl Repl {
prev_state = None;
}
Request::GetError => {
let errors = self.get_errors()?;
let (errors, _) = self.get_errors()?;
for e in errors {
error!("TSP error: {e}");
Self::print_data(state, ParsedResponse::TspError(e.to_string()))?;
Expand Down Expand Up @@ -418,10 +418,11 @@ impl Repl {
}

#[instrument(skip(self))]
fn get_errors(&mut self) -> Result<Vec<TspError>> {
fn get_errors(&mut self) -> Result<(Vec<TspError>, bool)> {
self.inst.write_all(b"print(_KIC.error_message())\n")?;
let mut errors: Vec<TspError> = Vec::new();
let mut err: String = String::new();
let mut prompt = false;
'error_loop: loop {
std::thread::sleep(Duration::from_micros(1));
let mut read_buf: Vec<u8> = vec![0; 1024];
Expand All @@ -446,12 +447,16 @@ impl Repl {

let parser = ResponseParser::new(err.as_bytes());
for response in parser {
if let ParsedResponse::TspError(e) = response {
if let ParsedResponse::TspError(e) = &response {
let x: TspError = serde_json::from_str(e.trim())?;
errors.push(x);
}
// in trebuchet for usbtmc connection prompt is getting in error query output, which got handled here
if response == ParsedResponse::Prompt {
prompt = true;
}
}
Ok(errors)
Ok((errors, prompt))
}

fn print_flush<D: Display>(string: &D) -> Result<()> {
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@tektronix/kic-cli",
"version": "0.21.0",
"version": "0.21.1",
"main": "index.js",
"bin": {
"windows-kic": "./bin/kic.exe",
Expand Down
Loading