チップの実装 #59
Merged
チップの実装 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cp-20
approved these changes
Dec 21, 2024
cp-20
approved these changes
Dec 21, 2024
Contributor
cp-20
left a comment
cp-20
left a comment
There was a problem hiding this comment.
全体的には超GOODです！！ 細かーいところをいくつかコメントしたのでサササッと確認してもらえれば嬉しいです～
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
props でラベルとチップの種類の切り替えを可能に、emits でクリック時に発火できるようにしました
svg の扱いと style が特に不安なので重点的に見ていただきたいです
close: #52