Skip to content

Conversation

@uni-kakurenbo
Copy link
Contributor

@uni-kakurenbo uni-kakurenbo commented Oct 31, 2025

概要

文脈: https://q.trap.jp/messages/0199cb80-5c7d-7b3c-8d87-1833ed050b24

なぜこの PR を入れたいのか

  • 非推奨で,挙動も怪しいため

動作確認の手順

  • 実際に補完等のテキスト置換が行われる操作をしてみて、現在と変わらないか、あるいはヘンな挙動が改善されているかを確認する

PR を出す前の確認事項

  • 動作確認ができている
  • 自分で一度コードを眺めて自分的に問題はなさそう

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.56%. Comparing base (c1742f3) to head (7c22c7e).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/composables/dom/useInsertText.ts 25.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4894      +/-   ##
==========================================
+ Coverage   13.52%   13.56%   +0.03%     
==========================================
  Files         708      708              
  Lines       32045    32049       +4     
  Branches      680      680              
==========================================
+ Hits         4335     4346      +11     
+ Misses      27698    27691       -7     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uni-kakurenbo uni-kakurenbo force-pushed the fix/use-set-range-text branch from ba5bf3d to e2a7a72 Compare October 31, 2025 00:40
@uni-kakurenbo uni-kakurenbo changed the title fix: 非推奨の text-field-edit ライブラリの代わりに setRangeText API を利用する fix: 一部の環境でテキスト置換の挙動がおかしくなる問題を修正 Oct 31, 2025
@uni-kakurenbo uni-kakurenbo self-assigned this Oct 31, 2025
@uni-kakurenbo uni-kakurenbo added the bug Something isn't working label Oct 31, 2025
@uni-kakurenbo uni-kakurenbo moved this from Inbox to In review in traQ Client Oct 31, 2025
@uni-kakurenbo uni-kakurenbo force-pushed the fix/use-set-range-text branch from e2a7a72 to 7c22c7e Compare October 31, 2025 10:10
@uni-kakurenbo
Copy link
Contributor Author

Undo ができなくなりそう

@uni-kakurenbo uni-kakurenbo moved this from In review to Need Discussion in traQ Client Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Need Discussion

Development

Successfully merging this pull request may close these issues.

2 participants