FIX: Fix undefined behavior warning with GCC #3434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/intelci: run |
Contributor
Author
|
/intelci: run |
david-cortes-intel
requested review from
ahuber21,
avolkov-intel,
icfaust and
razdoburdin
as code owners
Vika-F
reviewed
Nov 7, 2025
| { | ||
| const size_t iStart = iMain * simdBatchSize; | ||
| const size_t iStart = iMain * simdBatchSize; | ||
| #if defined(__GNUC__) && !defined(__clang__) |
Contributor
There was a problem hiding this comment.
Please add some comments here. For example:
Suggested change
| #if defined(__GNUC__) && !defined(__clang__) | |
| #if defined(__GNUC__) && !defined(__clang__) | |
| // g++ compiler cannot vectorize the further loops without this attribute | |
| // due to -Werror=aggressive-loop-optimizations, as since GCC 4.8 | |
| // "GCC now uses a more aggressive analysis to derive an upper bound | |
| // for the number of iterations of loops using constraints imposed by language standards" |
Contributor
Author
There was a problem hiding this comment.
Added a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a warning from GCC about potential undefined behavior, which cannot be encountered either way but lacks hints for it.
Checklist:
Completeness and readability
Testing