Skip to content

backport: cpu: aarch64: fix potential overflow in ACL strides #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: rls-v3.10
Choose a base branch
from
Open

backport: cpu: aarch64: fix potential overflow in ACL strides #4262

wants to merge 1 commit into from

Conversation

@fadara01
Copy link
Contributor

@fadara01 fadara01 commented Oct 31, 2025 •
edited
Loading

Description

Backporting #4261

Fix potential overflow in ACL strides which are uint32 as they extend Dimensions<uint32_t> - See: https://github.com/ARM-software/ComputeLibrary/blob/main/arm_compute/core/Strides.h#L42

Checklist

General

  • [Y] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • [Y] Have you formatted the code using clang-format?

Performance improvements

  • [N/A] Have you submitted performance data that demonstrates performance improvements?

New features

  • [N/A] Have you published an RFC for the new feature?
  • Was the RFC approved?
  • Have you added relevant tests?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • Have you added relevant regression tests?

RFC PR

  • Does RFC document follow the template?
  • Have you added a link to the rendered document?

@fadara01 fadara01 requested a review from a team as a code owner October 31, 2025 11:24
@github-actions github-actions bot added platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 backport labels Oct 31, 2025
@fadara01
Copy link
Contributor Author

fadara01 commented Oct 31, 2025

cc: @jondea @Ryo-not-rio @Sqvid

Sqvid
Sqvid previously requested changes Oct 31, 2025
View reviewed changes
@fadara01 @Sqvid
backport: cpu: aarch64: fix potential overflow in ACL strides
067d98d 
Co-authored-by: Siddhartha Menon <[email protected]>
Signed-off-by: Fadi Arafeh <[email protected]>
@fadara01 fadara01 force-pushed the fix_acl_stride_overflow_backport branch from ce58cea to 067d98d Compare October 31, 2025 12:49
@fadara01 fadara01 requested review from Ryo-not-rio and Sqvid October 31, 2025 12:53
@Sqvid Sqvid dismissed their stale review October 31, 2025 13:36

changes addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sqvid Sqvid Awaiting requested review from Sqvid

@Ryo-not-rio Ryo-not-rio Awaiting requested review from Ryo-not-rio

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

backport platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fadara01 @Sqvid @Ryo-not-rio