xe: jit: break codegen dependency on func_impl_t #4282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
Enables breaking codegen dependency on IR extensions implemented via `func_t`
rjoursler
force-pushed
the
rjoursle/break_func_codegen
branch
from
3089b72 to
493df40
Compare
rjoursler
force-pushed
the
rjoursle/break_func_codegen
branch
from
493df40 to
e954e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new interface
func_t::generate()which is intended to be used for code generation and refactorseltwise_t,reorder_t, andreduce_tto use this interface. The main benefit here is to break the codegen dependency on oneDNN post-ops helpers which is required for upstreaming.