cpu: x64: prepare some implementations for asynchronous runtime (pt. 2) #4295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:cpu-x64
Contributor
Author
|
make test |
Changing lambda capture to by copy can't accept a kernel wrapped into a unique_ptr as it's non-copyable. Need to de-consolidate execute calls.
dzarukin
force-pushed
the
dzarukin/async_runtime_prepare
branch
from
27becf0 to
1a2e3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second preparational part like #4188 setting up the path for backward conv support for async Eigen threadpool runtime.
The piece that separates execution path is forced by capture-by-copy which restricts copying of
const unique_ptr<...> &obviously.The rest changes for processing scales inside the parallel are identical.