Skip to content

x64: brdgmm kernel: do not pollute rbp by reg_zp_compensation #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

x64: brdgmm kernel: do not pollute rbp by reg_zp_compensation #4303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/cpu/x64/brgemm/jit_brdgmm_kernel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,8 @@ struct jit_brdgmm_kernel_base_t : public jit_base_brgemm_kernel_t {
regscratchpad_, rax, r23};
const injector_utils::reg64_savable_t reg_src_zero_point {
regscratchpad_, rax, r24};
// TODO: Make use of rbp under condition in reg_zp_compensation
const injector_utils::reg64_savable_t reg_zp_compensation {
regscratchpad_, rbp, r25};
regscratchpad_, r12, r25};
// abi_param1 is used in post-ops injector and by reg_aux_B,
// so need to be savable or use other registers
const injector_utils::reg64_savable_t reg_binary_params {
Expand Down