Refactoring of __parallel_set_union_op
#2457
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the __parallel_set_union_op function by extracting common optimization logic into a new __copy_union_when_disjointed function and introducing a _SumSize helper struct. The refactoring improves code reusability between set union and set symmetric difference operations.
- Extracted optimization logic for handling disjoint sequences into
__copy_union_when_disjointed - Added
_SumSizestruct to encapsulate size calculation logic - Updated both
__pattern_set_unionand__pattern_set_symmetric_differenceto use the new shared optimization function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| include/oneapi/dpl/pstl/algorithm_impl.h | Refactored __parallel_set_union_op into __copy_union_when_disjointed, added _SumSize struct, and updated set operation patterns to use the new shared logic |
| include/oneapi/dpl/pstl/algorithm_ranges_impl.h | Updated ranges-based set union and symmetric difference patterns to use the new shared optimization function and added necessary type aliases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_parallel_set_union_op
branch
7 times, most recently
from
13d8eb5 to
c66bb42
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_parallel_set_union_op
branch
from
c66bb42 to
aece43f
Compare
…n_disjointed() function
…et_union : replace __parallel_set_union_op call by __copy_union_when_disjointed + __parallel_set_op calls
…et_symmetric_difference : replace __parallel_set_union_op call by __copy_union_when_disjointed + __parallel_set_op calls
…ttern_set_union : replace __parallel_set_union_op call by __copy_union_when_disjointed + __parallel_set_op calls
…ttern_set_symmetric_difference : replace __parallel_set_union_op call by __copy_union_when_disjointed + __parallel_set_op calls
…n_op as unused anymore
SergeyKopienko
force-pushed
the
dev/skopienko/refactoring_of_parallel_set_union_op
branch
from
aece43f to
e84fb45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
__parallel_set_union_opfunction by extracting common optimization logic into a new__copy_union_when_disjointedfunction and introducing a_SumSizehelper struct. The refactoring improves code reusability between set union and set symmetric difference operations.__copy_union_when_disjointed_SumSizestruct to encapsulate size calculation logic__pattern_set_unionand__pattern_set_symmetric_differenceto use the new shared optimization function