[RFCs] Add rfcs directory #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aleksei Fedotov <[email protected]>
Co-authored-by: Aleksei Fedotov <[email protected]>
Co-authored-by: Aleksei Fedotov <[email protected]>
Co-authored-by: Aleksei Fedotov <[email protected]>
Co-authored-by: Aleksei Fedotov <[email protected]>
Co-authored-by: Aleksei Fedotov <[email protected]>
Co-authored-by: Aleksei Fedotov <[email protected]>
aepanchi
reviewed
Aug 26, 2024
|
Requesting @akukanov and @pavelkumbrasev for pending reviews |
Co-authored-by: Aleksei Fedotov <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Aleksei Fedotov <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Co-authored-by: Alexandra <[email protected]>
Made suggested wording changes. Co-authored-by: Alexandra <[email protected]> Co-authored-by: Aleksei Fedotov <[email protected]>
|
@akukanov Requesting for reviewing so this can be merged |
akukanov
reviewed
Sep 9, 2024
Comment on lines
+7
to
+15
| The motivation could be: | ||
| - Improved users experience for API changes and extensions. Code snippets to | ||
| showcase the benefits would be nice here. | ||
| - Performance improvements with the data, if available. | ||
| - Improved engineering practices. | ||
|
|
||
| Introduction may also include any additional information that sheds light on | ||
| the proposal, such as history of the matter, links to relevant issues and | ||
| discussions, etc. |
Contributor
There was a problem hiding this comment.
Would it make sense to format the boilerplate text int the template to be italicized and maybe put into some brackets?
Contributor
Author
There was a problem hiding this comment.
Looking at the rendered text, I think it's clear without brackets. But we can revisit later if people are confused.
|
@pavelkumbrasev Can you help address open review comments from @akukanov thereby enabling approval |
Co-authored-by: Pavel Kumbrasev <[email protected]>
Co-authored-by: Pavel Kumbrasev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a set of directories and sub-directories to support the oneTBB RFCs process.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information