Send ITT task end notifications with less delay (OV branch) #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akukanov
changed the title
akukanov
changed the title
Do not postpone the notifications for more than just a few unsuccessful attempts to find a non-local task, in order to avoid skewed results in profiling tools. (cherry picked from commit 681b96e)
akukanov
force-pushed
the
dev/improve-itt-task-end-ov-akukanov
branch
from
99ef3ad to
13af25d
Compare
akukanov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is cherry-picked from the oneTBB main branch, commit 681b96e.
The points where TBB worker threads issue ITT "task end" notifications (on the detection of a new task group context and on the leave of the task dispatch loop) may lead to significant delays with those, sometimes way after completion of the algorithm the "tasks" are supposed to indicate. That leads to skewed results in profiling tools that "consume" the ITT calls.
The patch proposes a change to issue the notification earlier, namely after two unsuccessful attempts to find a non-local task (via stealing, etc.).
Type of change
Tests
Documentation
Breaks backward compatibility?
Other information