Skip to content

Conversation

@kboyarinov
Copy link
Contributor

Description

Add new exit criteria for task_group dynamic dependencies.
Discussion link: #1685 (comment)

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.


Moving this feature to `supported` requires defining the semantic for this case.

### Preservation of submit arena
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the potential enhancement section? Seems to me that this is a design limitation that needs to be addressed to preserve semantics. In addition to concurrency, imagine that you run a task in an arena with constraints but it executes in a different arena with the different constraints -- such as as core type or CPU mask. It might also have different FP settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants