Optimising component compiler #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@willcosgrove let’s open PRs against this going forward. |
WIP support for source maps. This doesn't include a hook to apply the source maps to exceptions but that should be relatively easy to do later on. Closes #919
Input
```ruby
def view_template
h1 { "Hello" }
fragment :name do
h2 { "World" }
end
end
```
Output
```ruby
def view_template
__phlex_state__ = @_state
__phlex_buffer__ = __phlex_state__.buffer
__phlex_me__ = self
__phlex_should_render__ = __phlex_state__.should_render?; nil
__phlex_buffer__ << "<h1>Hello</h1>" if __phlex_should_render__; nil;
fragment :name do
__phlex_original_should_render__ = __phlex_should_render__
__phlex_should_render__ = __phlex_state__.should_render?;
__phlex_buffer__ << "<h2>World</h2>" if __phlex_should_render__; nil;
__phlex_should_render__ = __phlex_original_should_render__
end
end
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.