Fix: Header order -> section order #334
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn in the wrong place, not after _.uniq, as expected. Additionally it's "Browser Support" header was h3 instead h4, so that didn't help with semantics and navigation as well.
Since it is not a function description, I guess it is more logic to have this one at the end.
cht8687
force-pushed
the
master
branch
2 times, most recently
from
5559a1c to
bd9b25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
## Collection*header section### Browser Support for->#### Browser Support forso it is arranged within not adjacent of _.uniqWith### _.randomheader indentation## Referenceat the end, because it seems more appropriate thereThis allows to have the grouping with GitHubs header navigator:
and with the GitHub pages version of this readme, would then also list uniqWith in the collections section:
http://you-dont-need.github.io/You-Dont-Need-Lodash-Underscore/#/?id=_uniq