Upgrade to ruby 3.4.1 and Rails 7.2 #1287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, if you tried to spin up a new RMT with sqlite3 as an adapter you would be facing several issues. The first would be to manually set the adapter on `config/rmt.yml`, whereas an environment variable would suffice, as it's done for other database-related configuration. Migrations were also quite mysql-centric, and they are mostly not relevant since sqlite3 deployments are not even supported. Hence, we can safely skip most of the data migration paths. Signed-off-by: Miquel Sabaté Solà <[email protected]>
The upgrade to Rails 7.2 (as upgrades for many other gems) has been accidental, as Ruby 3.4.1 caused problems with old Rails (and other gems). Since the whole ruby upgrade also brought many changes bundler-wise, I decided to upgrade everything in one stroke. Signed-off-by: Miquel Sabaté Solà <[email protected]>
mssola
changed the title
mssola
force-pushed
the
to-ruby-3.4.1
branch
from
fa49ce9 to
75e18b9
Compare
Contributor
Author
|
I believe this is being handled somewhere else. Closing it... |
Contributor
|
Re-opening this PR to extract changes and make a task list |
- Created Gemfile-3.4.1 with essential gems for the application including Rails, Puma, MySQL, and development/testing tools. - Generated Gemfile.lock to lock the gem versions for consistent environment setup. - Added mise.toml to specify Ruby version and environment settings.
…by version in various files
- Created a new Gemfile-3.4 that dynamically loads the appropriate version-specific Gemfile based on the Ruby version. - Added Gemfile-3.4.lock with dependencies for Ruby 3.4, including actionpack, activerecord, and various testing and development tools.
…rmt-cli loading paths and require statements; modify schema for database consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does not just upgrade to Ruby 3.4.1, but it also upgrades a lot of gems underneath. This has been accidental by the way I needed to manage bundler. Anyways, I have split the Gemfile into both versions, and the
GemfileandGemfile.lockfiles are merely a symlink.There are still tests to be worked on, and the building surely needs a rebump (e.g. picking the right symlink?). Hence the
wiplabel.This PR also brings some improvements to the sqlite3 setup, which I was only able to reproduce while performing the upgrade.