Upgrade to ruby 3.4.1 and Rails 7.2

.github/workflows/lint-unit.yml

@@ -30,10 +30,12 @@ jobs:
       matrix:
         # we need to test the Ruby versions of the products we release RMT for,
         # those are: SLE15 (2.5.8, 2.5.9)
-        ruby-version: ['2.5.8', '2.5.9']
+        # ruby-version: ['2.5.8', '2.5.9']
         # skipping Ruby3 tests for now, because RMT isn't Ruby3 compatible yet, and the failing 
         # tests confuse the team.
-        # ruby-version: ['2.5.8', '2.5.9', '3.0.3']
+        ruby-version: ['2.5.9', '3.4.1']
+    env:
+      BUNDLE_GEMFILE: Gemfile-${{matrix.ruby-version}}
 
     services:
       mysql:
@@ -77,6 +79,10 @@ jobs:
         run: |
           bundle exec rubocop -D
 
+      - name: Run zeitwerk check
+        run: |
+          bundle exec rails zeitwerk:check
+
       - name: Prepare database
         run: |
           bundle exec rails db:drop db:create db:migrate

.rubocop.yml

@@ -9,7 +9,7 @@ inherit_mode:
     - Exclude
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 3.4
   SuggestExtensions: false
   NewCops: enable
   Exclude:
@@ -23,8 +23,8 @@ AllCops:
     - package/**/*
 
 
-Style/TrailingUnderscoreVariable:
-  Enabled: false
+Naming/PredicatePrefix:
+  Enabled: true
 
 RSpec/ExampleLength:
   Exclude:
@@ -77,3 +77,108 @@ RSpec/MessageChain:
 # Count: 107 offenses
 RSpec/SubjectStub:
   Enabled: false
+
+FactoryBot/SyntaxMethods:
+  Enabled: false
+
+FactoryBot/ConsistentParenthesesStyle:
+  Enabled: false
+
+RSpec/IndexedLet:
+  Enabled: false
+
+RSpecRails/HaveHttpStatus:
+  Enabled: false
+
+Rails/HttpStatus:
+  Enabled: false
+
+RSpecRails/InferredSpecType:
+  Enabled: false
+
+Style/RedundantConstantBase:
+  Enabled: false
+
+RSpec/MatchArray:
+  Enabled: false
+
+RSpec/BeNil:
+  Enabled: false
+
+RSpec/ClassCheck:
+  Enabled: false
+
+RSpec/VerifiedDoubleReference:
+  Enabled: false
+
+RSpec/ExampleWording:
+  Enabled: false
+
+RSpec/ReceiveMessages:
+  Enabled: false  
+
+Style/RedundantParentheses:
+  Enabled: false
+
+Style/FileNull:
+  Enabled: false
+
+Rails/StripHeredoc:
+  Enabled: false
+
+Performance/StringIdentifierArgument:
+  Enabled: false
+
+Layout/HeredocIndentation:
+  Enabled: false
+
+FactoryBot/FactoryAssociationWithStrategy:
+  Enabled: false
+
+Rails/DurationArithmetic:
+  Enabled: false
+
+FactoryBot/AssociationStyle:
+  Enabled: false
+
+Style/NumericPredicate:
+  Enabled: false
+
+Style/ReturnNilInPredicateMethodDefinition:
+  Enabled: false
+
+Rails/FindEach:
+  Enabled: false
+
+RSpec/RemoveConst:
+  Enabled: false
+
+RSpec/NoExpectationExample:
+  Enabled: false
+
+Style/RedundantStringEscape:
+  Enabled: false
+
+Style/RedundantFormat:
+  Enabled: false
+
+RSpec/SpecFilePathFormat:
+  Enabled: false
+
+Rails/RedundantActiveRecordAllMethod:
+  Enabled: false
+
+Rails/ThreeStateBooleanColumn:
+  Enabled: false
+
+Rails/SelectMap:
+  Enabled: false
+
+Rails/RootPathnameMethods:
+  Enabled: false
+
+Performance/MapMethodChain:
+  Enabled: false
+
+Style/SafeNavigationChainLength:
+  Enabled: false