Fix tests #755
Merged
Fix tests #755
+29
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mao-sz
approved these changes
Nov 1, 2025
Contributor
mao-sz
left a comment
mao-sz
left a comment
There was a problem hiding this comment.
Cheers for looking into this further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Some tests are failing due to Mock structure
This PR
Fixes test mocks and cleaning up. The mocks were not being structured correctly, which should have failed, so I'm not sure how this made it in to begin with. As for runtime, I didn't have to fix anything in there. I tested the command before the latest change for it to work in different channels, so I'm going to assume whoever worked on that tested it and going to assume it works fine, no one seem to have noticed issues using this command
Issue
Closes #754