fix: quiz submission before prerequisites #135
Conversation
Current Behavior: - Users could submit quizzes without prerequisites being completed. - Backend would reject submissions after answers were already filled, causing frustration. Fix: - Added client-side prerequisite check before allowing quiz submission. - Users are now prompted to complete missing prerequisites before submitting answers. - Ensures a smoother user experience and prevents unnecessary time waste. Signed-off-by: Sunny <[email protected]>
bashSunny101
force-pushed
the
fix-quiz-prerequisites
branch
from
3377f1d to
c5190b3
Compare
|
This PR addresses the quiz submission issue and fixes the submission flow. Could you please review it when you get a chance and merge if it looks good? Thanks! |
|
Hi @saurabhraghuvanshii , This PR ( Thanks in advance! |
|
@bashSunny101 please be patient and wait we can't merge pr directly. |
saurabhraghuvanshii
requested review from
ARYANSHAH1567,
Namanv0509 and
aabidsofi19
layouts/test/single.html
Outdated
|
|
||
| // Check for existing submission | ||
| const existingGradeResult = window.academyContext?.progressTracker?.progress?.grades[testId] || null; | ||
|
|
RanitMukherjee
left a comment
RanitMukherjee
left a comment
There was a problem hiding this comment.
Good work 🚀 , LGTM as far as the code is concerned!
saurabhraghuvanshii
requested review from
Vincamine
and removed request for
ARYANSHAH1567
|
Kindly let me know if any changes are to be made😊 |
|
Hi, |
|
@bashSunny101 please message on slack for it. I don't have access. |
Signed-off-by: Sunny Pal <[email protected]>
|
@bashSunny101 the issue has already been fixed in a separate pr and released . We can close this pr . Don't feel disheartened there are more issues than we can count .. |
|
Thanks for the update. I just wanted to clarify — I had opened this PR earlier and have been actively following up with comments and feedback. I didn’t notice any other PR addressing the same issue before mine. Could you please confirm which PR fixed it? It’ll help me understand the changes better and avoid overlaps in the future. Either way, I really appreciate the feedback and will definitely look for more issues to contribute to! 😊 |
4 participants
Current Behavior:
Fix:
Notes for Reviewers
This PR fixes #122
Signed commits