Skip to content

fix: quiz submission before prerequisites #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: quiz submission before prerequisites #135

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5190b3
fix: quiz submission before prerequisites
bashSunny101 Oct 2, 2025
853fd11
Merge branch 'master' into fix-quiz-prerequisites
bashSunny101 Oct 3, 2025
4115fa1
Merge branch 'master' into fix-quiz-prerequisites
saurabhraghuvanshii Oct 8, 2025
5035db0
Merge branch 'master' into fix-quiz-prerequisites
bashSunny101 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions layouts/test/single.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,25 +559,33 @@ <h3 class="mb-3">Test details</h6>
return `
<a href="${preqLink(preq)}" class='pending-preq preq'>
<i class="bi bi-x-circle-fill text-white me-1"></i>
<div class="">
${preq.title}
<div>
<strong>${preq.title}</strong><br/>
<span class="text-danger">You must complete this before taking the test.</span>
</div>
</a>`
};
const completedPreq = (preq) => {
return `
<a href="${preqLink(preq)}" class='completed-preq preq'>
<i class="bi bi-check-circle-fill text-white me-1"></i>
<div class="">
<div>
${preq.title}
</div>
</a>`;
};


prerequisitesList.innerHTML = prerequisites.map(preq => {
return isPrerequisitePending(preq) ? pendingPreq(preq) : completedPreq(preq);
}).join('');
if (pendingPreqs.length > 0) {
prerequisitesList.innerHTML = prerequisites.map(preq => {
return isPrerequisitePending(preq) ? pendingPreq(preq) : completedPreq(preq);
}).join('');
// Add a clear, actionable message
prerequisitesList.insertAdjacentHTML('beforebegin', `<div class="alert alert-warning" role="alert">
<strong>Action Required:</strong> You need to complete all prerequisites before you can start this test. Click on each prerequisite to view and complete it.
</div>`);
} else {
prerequisitesList.innerHTML = '';
}
}

function RenderSubmissionResult(data) {
Expand Down Expand Up @@ -752,10 +760,7 @@ <h3 class="mb-3">Test details</h6>

document.getElementById("go-back").addEventListener("click", HandleGoBack);
document.getElementById("quiz-form").addEventListener("submit", HandleQuizSubmission);

document.getElementById("start-test-btn").addEventListener("click", () => {
showState('taking_test');
});
// start-test-btn click logic handled in academyContextReady for prerequisite check

document.getElementById("hide-submission-btn").addEventListener("click", () => {
showState('submitted_test');
Expand All @@ -780,16 +785,29 @@ <h3 class="mb-3">Test details</h6>
return;
}

const pending_preqs = window.academyContext.progressTracker?.getPendingPrerequisites(prerequisites) || [];
// Prerequisite check before test start
let pending_preqs = window.academyContext.progressTracker?.getPendingPrerequisites(prerequisites) || [];
let prerequisitesMet = pending_preqs.length === 0;

// Only allow starting test if prerequisites are met
const startTestBtn = document.getElementById("start-test-btn");
if (startTestBtn) {
startTestBtn.onclick = function() {
if (!prerequisitesMet) {
showState('missing_prerequisites', pending_preqs);
} else {
showState('taking_test');
}
};
}

if (pending_preqs.length > 0) {
if (!prerequisitesMet) {
showState('missing_prerequisites', pending_preqs);
return;
}

// Check for existing submission
const existingGradeResult = window.academyContext?.progressTracker?.progress?.grades[testId] || null;

Copy link
Member

@RanitMukherjee RanitMukherjee Oct 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems unnecessary

if (existingGradeResult) {
showState('submitted_test', existingGradeResult);
} else {
Expand Down