-
Notifications
You must be signed in to change notification settings - Fork 56
feat: Instrument native WebSocket API #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Added socketId to error objects for better linkage with WebSocket events. - Removed deprecated WebSocket event handling code and associated metrics. - Introduced new HTML test files for WebSocket error handling and multi-type message sending. - Updated existing tests to validate WebSocket metrics and error linkage. - Implemented a WebSocket echo server for testing various data types. - Enhanced third-party WebSocket wrappers to support new feature flags.
Supportability Metric Usage Changes:No matching changes found Supportability Metrics .md File Changes:supportability_metrics.md was changed? New supportability metrics require changes to supportability_metrics.md, as well as a new PR to Angler. Please ensure an Angler PR is created and linked to this PR. |
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
==========================================
+ Coverage 88.47% 88.58% +0.11%
==========================================
Files 206 205 -1
Lines 7763 7852 +89
Branches 1593 1615 +22
==========================================
+ Hits 6868 6956 +88
- Misses 782 788 +6
+ Partials 113 108 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Re-introduces
WebSocketinstrumentation to capture metrics about its usage. When enabled by the 'websockets' feature flag, the agent will wrap the native API to record usage data around each instance and send it to New Relic as a "WebSocket" event on close.Overview
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-455564
Testing