Improve icon tool right-to-left handling; remove pointless icon. #4790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crhallberg
approved these changes
Oct 30, 2025
| // If this is a right-to-left icon, display it on the same line with the left-to-right version: | ||
| if ($icon === "$lastIcon-rtl") { | ||
| array_pop($icons); // discard the previous uncombined version of the line before adding the combined version | ||
| $icons[] = $this->icon($lastIcon) . '/' . $this->icon($icon) . ' ' . $this->escapeHtml($lastIcon) . ' (ltr/rtl)<br>'; |
Contributor
There was a problem hiding this comment.
Would it make sense to put the icon at the end of the label, to see it in proper text position?
Member
Author
There was a problem hiding this comment.
Do you mean something like:
[ltr icon] (ltr) icon-label [rtl icon] (rtl)
? I'd have to try it to see how I feel about it, though my gut feeling is that the advantage to the current approach is that all the icons line up in a neat column and can be more easily scanned/reviewed. If some icons floated on the other side of the text, it might be more visually confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the icon dev tool so that it shows left-to-right/right-to-left versions of icons on a single line. This makes it easier to compare configurations that have ltr/rtl versions with those that do not, without conceptually related icons ending up in different visual positions on the page.
The PR also removes a pointless right-to-left definition that is identical to its left-to-right counterpart.