Improve icon tool right-to-left handling; remove pointless icon.

themes/bootstrap5/templates/devtools/icon.phtml

@@ -4,10 +4,25 @@
   $this->headTitle($title);
   $this->breadcrumbs()->set('Development Tools', $this->url('devtools-home'))
     ->add($title, active: true);
+  $icons = [];
+  $lastIcon = '';
+  foreach ($aliases as $icon) {
+    // If this is a right-to-left icon, display it on the same line with the left-to-right version:
+    if ($icon === "$lastIcon-rtl") {
+      // There is no current mechanism to force display of left-to-right icons in right-to-left mode, so we'll just
+      // ignore the alternate version in this situation.
+      if (!$this->layout()->rtl) {
+        // If we're in left-to-right mode, we can display LTR and RTL versions on the same line; we need to
+        // discard the previous uncombined version of the line before adding the combined version
+        array_pop($icons);
+        $icons[] = $this->icon($lastIcon) . ' (ltr) ' . $this->escapeHtml($lastIcon)
+          . ' (rtl) ' . $this->icon($icon) . '<br>';
+      }
+    } else {
+      $icons[] = $this->icon($icon) . ' ' . $this->escapeHtml($icon) . '<br>';
+    }
+    $lastIcon = $icon;
+  }
 ?>
 <h1><?=$titleEsc?></h1>
-<div class="devtools-icon-container">
-  <?php foreach ($aliases as $icon): ?>
-    <?=$this->icon($icon)?> <?=$this->escapeHtml($icon)?><br>
-  <?php endforeach; ?>
-</div>
+<div class="devtools-icon-container"><?=implode('', $icons)?></div>

themes/bootstrap5/theme.config.php

@@ -282,7 +282,6 @@
             'overdrive-help' => 'FontAwesome:question-circle',
             'overdrive-place-hold' => 'Alias:place-hold',
             'overdrive-return' => 'FontAwesome:undo',
-            'overdrive-return-rtl' => 'FontAwesome:undo',
             'overdrive-sign-in' => 'FontAwesome:sign-in',
             'overdrive-success' => 'FontAwesome:check',
             'overdrive-suspend-hold' => 'Alias:place-hold',